Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Fix einsum gradient #18482

Merged
merged 1 commit into from
Jun 5, 2020
Merged

[Numpy] Fix einsum gradient #18482

merged 1 commit into from
Jun 5, 2020

Conversation

hanke580
Copy link
Contributor

@hanke580 hanke580 commented Jun 4, 2020

Description

This is a backport of PR #18419
Fix einsum gradient in one dim situation

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @hanke580 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, clang, miscellaneous, unix-gpu, centos-gpu, windows-gpu, unix-cpu, website, sanity, centos-cpu, edge]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@hanke580 hanke580 changed the title * Fix einsum gradient [Numpy] Fix einsum gradient Jun 4, 2020
@hanke580
Copy link
Contributor Author

hanke580 commented Jun 4, 2020

backport of einsum
@ciyongch

@ciyongch
Copy link
Contributor

ciyongch commented Jun 4, 2020

website job seems get stuck, please help to re-trigger the job.

@hanke580
Copy link
Contributor Author

hanke580 commented Jun 4, 2020

@mxnet-bot run ci [website]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [website]

ciyongch
ciyongch approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@ciyongch ciyongch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Ping @leezu @TaoLv @pengzhao-intel to help merge.

@pengzhao-intel pengzhao-intel merged commit b1bb307 into apache:v1.7.x Jun 5, 2020
leezu pushed a commit to leezu/mxnet that referenced this pull request Oct 1, 2020
@hanke580 @leezu
* Fix einsum gradient (apache#18482)
3fe38da
samskalicky pushed a commit that referenced this pull request Oct 2, 2020
@leezu @hanke580
@sxjscience @haojin2 @xidulu @yijunc @vexilligera @ciyongch @TaoLv
Backport PRs in v1.7.x missing from v1.x to v1.8.x (#19262)
371b312 
* * Fix einsum gradient (#18482)

* [v1.7.x] Backport PRs of numpy features (#18653)

* add zero grad for npi_unique (#18080)

* fix np.clip scalar input case (#17788)

* fix true_divide (#18393)

Co-authored-by: Hao Jin <[email protected]>
Co-authored-by: Xi Wang <[email protected]>

* [v1.7.x] backport mixed type binary ops to v1.7.x (#18649)

* Fix Windows GPU CI (#17962)

Update Windows CI to use VS 2019 and enable x64 bit toolchain. Previously we are using an older 32 bit toolchain causing OOM errors during linking. Switching to x64 bit toolchain on the older VS version previously used by the CI was attempted in #17912 and did not work. Update to Cuda 10.2 as it is required by VS 2019. Switch to ninja-build on Windows to speed up build as ninja-build is now preinstalled. Remove logic to install cmake 3.16 on every PR as cmake 3.17 is now preinstalled. Add build retrials due to cuda thrust + VS2019 flakyness.

Co-authored-by: vexilligera <[email protected]>

* backport mixed type

Co-authored-by: Leonard Lausen <[email protected]>
Co-authored-by: vexilligera <[email protected]>

* revise activations (#18700)

* [v1.6] Fix the monitor_callback invalid issue during calibration with variable input shapes (#18632) (#18703)

* Fix the monitor_callback invalid issue during calibration with variable input shapes

* retrigger CI

* Add UT for monitor check and disable codecov

Co-authored-by: Tao Lv <[email protected]>

* Fail build_windows.py if all retries failed (#18177)

* Update to thrust 1.9.8 on Windows (#18218)

* Update to thrust 1.9.8 on Windows

* Remove debug logic

* Re-enable build retries on MSVC (#18230)

Updating thrust alone did not help. Similar issues (though less often) still
occur with updated thrust, and also with nvidia cub. Tracked upstream at
NVIDIA/thrust#1090

Co-authored-by: Ke Han <[email protected]>
Co-authored-by: Xingjian Shi <[email protected]>
Co-authored-by: Hao Jin <[email protected]>
Co-authored-by: Xi Wang <[email protected]>
Co-authored-by: Yijun Chen <[email protected]>
Co-authored-by: vexilligera <[email protected]>
Co-authored-by: ciyong <[email protected]>
Co-authored-by: Tao Lv <[email protected]>
samskalicky pushed a commit to samskalicky/incubator-mxnet that referenced this pull request Oct 2, 2020
@leezu @hanke580
@sxjscience @haojin2 @xidulu @yijunc @vexilligera @ciyongch @TaoLv
Backport PRs in v1.7.x missing from v1.x to v1.8.x (apache#19262)
d06be8c 
* * Fix einsum gradient (apache#18482)

* [v1.7.x] Backport PRs of numpy features (apache#18653)

* add zero grad for npi_unique (apache#18080)

* fix np.clip scalar input case (apache#17788)

* fix true_divide (apache#18393)

Co-authored-by: Hao Jin <[email protected]>
Co-authored-by: Xi Wang <[email protected]>

* [v1.7.x] backport mixed type binary ops to v1.7.x (apache#18649)

* Fix Windows GPU CI (apache#17962)

Update Windows CI to use VS 2019 and enable x64 bit toolchain. Previously we are using an older 32 bit toolchain causing OOM errors during linking. Switching to x64 bit toolchain on the older VS version previously used by the CI was attempted in apache#17912 and did not work. Update to Cuda 10.2 as it is required by VS 2019. Switch to ninja-build on Windows to speed up build as ninja-build is now preinstalled. Remove logic to install cmake 3.16 on every PR as cmake 3.17 is now preinstalled. Add build retrials due to cuda thrust + VS2019 flakyness.

Co-authored-by: vexilligera <[email protected]>

* backport mixed type

Co-authored-by: Leonard Lausen <[email protected]>
Co-authored-by: vexilligera <[email protected]>

* revise activations (apache#18700)

* [v1.6] Fix the monitor_callback invalid issue during calibration with variable input shapes (apache#18632) (apache#18703)

* Fix the monitor_callback invalid issue during calibration with variable input shapes

* retrigger CI

* Add UT for monitor check and disable codecov

Co-authored-by: Tao Lv <[email protected]>

* Fail build_windows.py if all retries failed (apache#18177)

* Update to thrust 1.9.8 on Windows (apache#18218)

* Update to thrust 1.9.8 on Windows

* Remove debug logic

* Re-enable build retries on MSVC (apache#18230)

Updating thrust alone did not help. Similar issues (though less often) still
occur with updated thrust, and also with nvidia cub. Tracked upstream at
NVIDIA/thrust#1090

Co-authored-by: Ke Han <[email protected]>
Co-authored-by: Xingjian Shi <[email protected]>
Co-authored-by: Hao Jin <[email protected]>
Co-authored-by: Xi Wang <[email protected]>
Co-authored-by: Yijun Chen <[email protected]>
Co-authored-by: vexilligera <[email protected]>
Co-authored-by: ciyong <[email protected]>
Co-authored-by: Tao Lv <[email protected]>
samskalicky added a commit that referenced this pull request Oct 3, 2020
@samskalicky @leezu
@hanke580 @sxjscience @haojin2 @xidulu @yijunc @vexilligera @ciyongch @TaoLv
Backport PRs in v1.7.x missing from v1.x to v1.8.x (#19262) (#19281)
4cd3bed 
* * Fix einsum gradient (#18482)

* [v1.7.x] Backport PRs of numpy features (#18653)

* add zero grad for npi_unique (#18080)

* fix np.clip scalar input case (#17788)

* fix true_divide (#18393)

Co-authored-by: Hao Jin <[email protected]>
Co-authored-by: Xi Wang <[email protected]>

* [v1.7.x] backport mixed type binary ops to v1.7.x (#18649)

* Fix Windows GPU CI (#17962)

Update Windows CI to use VS 2019 and enable x64 bit toolchain. Previously we are using an older 32 bit toolchain causing OOM errors during linking. Switching to x64 bit toolchain on the older VS version previously used by the CI was attempted in #17912 and did not work. Update to Cuda 10.2 as it is required by VS 2019. Switch to ninja-build on Windows to speed up build as ninja-build is now preinstalled. Remove logic to install cmake 3.16 on every PR as cmake 3.17 is now preinstalled. Add build retrials due to cuda thrust + VS2019 flakyness.

Co-authored-by: vexilligera <[email protected]>

* backport mixed type

Co-authored-by: Leonard Lausen <[email protected]>
Co-authored-by: vexilligera <[email protected]>

* revise activations (#18700)

* [v1.6] Fix the monitor_callback invalid issue during calibration with variable input shapes (#18632) (#18703)

* Fix the monitor_callback invalid issue during calibration with variable input shapes

* retrigger CI

* Add UT for monitor check and disable codecov

Co-authored-by: Tao Lv <[email protected]>

* Fail build_windows.py if all retries failed (#18177)

* Update to thrust 1.9.8 on Windows (#18218)

* Update to thrust 1.9.8 on Windows

* Remove debug logic

* Re-enable build retries on MSVC (#18230)

Updating thrust alone did not help. Similar issues (though less often) still
occur with updated thrust, and also with nvidia cub. Tracked upstream at
NVIDIA/thrust#1090

Co-authored-by: Ke Han <[email protected]>
Co-authored-by: Xingjian Shi <[email protected]>
Co-authored-by: Hao Jin <[email protected]>
Co-authored-by: Xi Wang <[email protected]>
Co-authored-by: Yijun Chen <[email protected]>
Co-authored-by: vexilligera <[email protected]>
Co-authored-by: ciyong <[email protected]>
Co-authored-by: Tao Lv <[email protected]>

Co-authored-by: Leonard Lausen <[email protected]>
Co-authored-by: Ke Han <[email protected]>
Co-authored-by: Xingjian Shi <[email protected]>
Co-authored-by: Hao Jin <[email protected]>
Co-authored-by: Xi Wang <[email protected]>
Co-authored-by: Yijun Chen <[email protected]>
Co-authored-by: vexilligera <[email protected]>
Co-authored-by: ciyong <[email protected]>
Co-authored-by: Tao Lv <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ciyongch ciyongch ciyongch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanke580 @mxnet-bot @ciyongch @pengzhao-intel